Repository navigation
Compare sub claims as strings in validate_user_claim - #704
Merged
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
daggerhart
approved these changes
Nov 20, 2026
daggerhart
left a comment
Collaborator
There was a problem hiding this comment.
Looks great. Thanks for the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
validate_user_claim()compares the id_tokensuband the userinfosubwith!==, so an IdP that returns"35"in the id_token and35in the userinfo response fails withincorrect-user-claim. This compares both values as strings, the same wayvalidate_existing_user_link()already compares identities. I don't have a miniOrange server to test against, so I reproduced it with the reporter's debug values in a unit test.Closes #673 .
How to test the changes in this Pull Request:
composer phpunit -- --filter test_validate_user_claim_with_integer_sub.validate_user_claim( array( 'sub' => 35 ), array( 'sub' => '35' ) )returnsincorrect-user-claim; after the change it returns true.subvalue is still refused withincorrect-user-claim.Other information:
Changelog entry